Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-294): support lessOrEqual(le) and greaterOrEqual(ge) #310

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Mar 18, 2024

Proposal for issue-294

  • Added support for lessOrEqual aka le and greaterOrEqual aka (ge)
  • Updated documentation
  • Added tests
  • Added example assertions to test/data/v3/basic/tests/deployment_test.yaml

Note. Edge cases where one value is int, other is float or string could be cast to int or float left for future. They could be added in follow-up if there is a demand and feedback

ivankatliarchuk and others added 8 commits March 18, 2024 01:16
* main: (37 commits)
  Simplify code and make documentSelector tests more useful, define all scenario's and update documentation.
  issue-312: documentselector support greedy pattern matching
  issue-312: documentselector support greedy pattern matching
  issue-312: documentselector support greedy pattern matching
  issue-312: documentselector support case with any template
  issue-312: documentselector support cases for inside and outsdie the tests block
  issue-312: documentselector support cases for inside and outsdie the tests block
  fix(issue-312): inline test naming and description
  fix(issue-312): added hasDocuments to test cases
  issue-312: documentselector support cases for inside and outsdie the tests block
  issue-312: documentselector support cases for inside and outsdie the tests block
  issue-312: documentselector support cases for inside and outsdie the tests block
  Enable windows github action, to double check everything
  Update dependencies, makefile and changelog.
  Correct path in testresult.
  Add additional attributes for the binary files.
  Add attribute to ensure same eol handling on all systems, change path to filepath for proper filepath handling.
  Correct filter in copyvalues to ensure right template files are filtered, including correcting tests.
  Update sonar project properties to ignore kubernetes test resources as the resources will not be deployed.
  Add additional validation and separate complex methods into multiple smaller methods for better maintenance.
  ...
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
@ivankatliarchuk
Copy link
Contributor Author

Hi @quintush. Any chance to add this capability to the next release? I'll rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant