Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new color theme 'iroaseta' #10381

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add new color theme 'iroaseta' #10381

wants to merge 16 commits into from

Conversation

YardQuit
Copy link

Dark color theme with subdued text colors

postsolar
postsolar suggested changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@postsolar postsolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could also add "ui.virtual.jump-label"?

runtime/themes/iroaseta.toml Outdated Show resolved Hide resolved
@YardQuit
Copy link
Author

Maybe you could also add "ui.virtual.jump-label"?
Thanks, this feature isn't present in the fedora 39 version yet. I absolutely what to add this with the modifiers = ["reversed"] setting. Can I do it from this pull request or do I need to work from my fork and redo the pull request? My first time doing this :)

@YardQuit
Update iroaseta.toml
5ba97d0 
Add virtual jump label theme setting
@YardQuit
Copy link
Author

YardQuit commented Apr 14, 2024 •
edited

Maybe you could also add "ui.virtual.jump-label"?
Thanks, this feature isn't present in the fedora 39 version yet. I absolutely what to add this with the modifiers = ["reversed"] setting. Can I do it from this pull request or do I need to work from my fork and redo the pull request? My first time doing this :)

I believe I figured it out, the setting should be in place now.

@kirawi kirawi added the A-theme Area: Theme and appearence related label Apr 14, 2024
the-mikedavis
the-mikedavis reviewed Apr 15, 2024
View reviewed changes
runtime/themes/iroaseta.toml Outdated Show resolved Hide resolved
runtime/themes/iroaseta.toml Outdated Show resolved Hide resolved
YardQuit and others added 4 commits April 15, 2024 20:59
@YardQuit @the-mikedavis
Update runtime/themes/iroaseta.toml
5989090 
Co-authored-by: Michael Davis <[email protected]>
@YardQuit
Update iroaseta.toml
4b354a1 
update storage. keyword.storage. according to suggestion, and update color.
@YardQuit
Update iroaseta.toml
8e7689c 
remove unused palette
@YardQuit
Update iroaseta.toml
9c5d30f 
add missing setting for bufferline
@YardQuit
Update iroaseta.toml
2b56e2d 
update diagnostic fg color
@YardQuit
Update iroaseta.toml
b9bcc81 
I made the config more comprehensive and took all available themes settings from the manual. Some are commented out though.
@YardQuit
Update iroaseta.toml
bcfb646 
add missing colors
@YardQuit
Merge branch 'helix-editor:master' into new_color_theme
74cdccc
@YardQuit
Update iroaseta.toml
b312885 
Made some final adjustments to the color theme to improve visibility and reduce eye strain.
the-mikedavis
the-mikedavis reviewed Apr 29, 2024
View reviewed changes
runtime/themes/iroaseta.toml Outdated Show resolved Hide resolved
runtime/themes/iroaseta.toml Outdated Show resolved Hide resolved
@archseer archseer mentioned this pull request Apr 30, 2024
Open
@YardQuit
Update iroaseta.toml
e7630fe 
remove redundant settings
@YardQuit
Update iroaseta.toml
eaf5499 
update color name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@postsolar postsolar postsolar approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YardQuit @the-mikedavis @postsolar @kirawi