Feat/675 on chain ouis devaddrs #435
Conversation
| @@ -43,14 +42,18 @@ enum action_v1 { | |||
| // Define an organisation | |||
| message org_v1 { | |||
| uint64 oui = 1; | |||
| // On chain address | |||
| bytes address = 2; | |||
There was a problem hiding this comment.
we can't change this proto like this without breaking any existing clients. we can add fields and that should be relatively safe for the old stuff to handle but changing the order of existing fields or adding fields in order ahead of existing fields will need an org_v2 message to avoid a breaking change. unless we want to consider updating the "official cli" and the client in the iot oracles the only priority and let any other consumers deal with the fallout.
maybe that's acceptable in this special case since the shift to solana for apis using this particular data structure are going to be broken without an update no matter what ?
There was a problem hiding this comment.
Good point actually, we need to decide if we want to v2 or nuke v1? I think we would be broken no matter what but maybe we v2, deprecate v1 and remove it at a later date.
There was a problem hiding this comment.
Only reason I don’t think it’s straightforward is b/c there are still methods that return that data structure that by the proto spec would be expected to still work
There was a problem hiding this comment.
Yeah the data structure is going to change completely once we do the shift. I can do the v2 and deprecate v1 if thats the consensus?
There was a problem hiding this comment.
Think I deprecated it properly, lemme know if thats how we want to do it
Oui and Devadders are moving onchain.
All write commands will be interacting directly with the solana blockchain via a solana_client now.