Add gateway to packet_router_packet_down_v1 #316
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macpie
force-pushed
the
macpie/OneStreamToRuleThemAll
branch
from
004904b to
56386be
Compare
madninja
reviewed
Jun 28, 2023
| @@ -71,6 +71,7 @@ message packet_router_packet_down_v1 { | |||
| bytes payload = 1; | |||
| window_v1 rx1 = 2; | |||
| window_v1 rx2 = 3; | |||
| bytes gateway = 4; | |||
There was a problem hiding this comment.
Why add this overhead to every packet headed to the gateway?
There was a problem hiding this comment.
No, this is an experiment to handle data from Router to HPR with less streams.
There was a problem hiding this comment.
Gotcha but it’s also the proto message that the gateway receives right? If so you may want to put the downlink packet in an envelope with the gateway in the outer envelope
There was a problem hiding this comment.
We could leave it empty when it goes to gateway
There was a problem hiding this comment.
Seems like that breaks some system boundaries in favor of some optimization. Let’s chat this through before nailing it down
7 tasks
devilish66694
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.