Add network field to metadata #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gonna run test locally make sure everything good before merge |
|
Issued PR jpmeijers#2 to fix tests |
Fix hpr_protocol_gwmp_SUITE
michaeldjeffrey
approved these changes
Feb 13, 2024
macpie
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #285
In the metadata for a gateway/hotspot that is sent to ChirpStack, explicitly state that this packet comes from the Helium IoT network. This would help services on the other side of ChirpStack know for sure if the packet was received by Helium, without having to guess from the other metadata fields.