Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - AbstractConfigurableExtension native-image fix #8771

Merged

Conversation

romain-grecourt
Copy link
Contributor

Description

Update AbstractConfigurableExtension to lookup config values lazily.
This resolves an issue with native-image where the config values are fixed at build-time.

Documentation

None

This resolves an issue with native-image where the config values are fixed at build-time.
@romain-grecourt romain-grecourt added this to the 4.0.9 milestone May 17, 2024
@romain-grecourt romain-grecourt self-assigned this May 17, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 17, 2024
ljnelson
ljnelson previously approved these changes May 20, 2024
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway minor comments LGTM in general

- Use a function to remove the explicit use of MicroProfile config
- Rename ConfiguredProperties to ComputedProperties
@romain-grecourt romain-grecourt merged commit 6f1884a into helidon-io:main May 20, 2024
12 checks passed
@romain-grecourt romain-grecourt deleted the lazy-cdi-common-configurable branch May 20, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x MP native-image OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants