Add --json flag for the status sub-command
#23
Conversation
This feature allows easier access to some of the state variables for scripts doing actions based on the state of git-team. One example where this feature might be useful is to temporary disable git team, install some pre-commit hocks and afterwards re-enabling it with the same, previously configured, co-authors.
hekmekk
left a comment
hekmekk
left a comment
There was a problem hiding this comment.
Thanks very much for the feature 💐
Looking forward to merging it. Just got 2 open points, which I'm sure can be resolved quickly 😉
| encoder.SetEscapeHTML(false) | ||
| err := encoder.Encode(theState) | ||
| if err != nil { | ||
| return buffer.String() |
There was a problem hiding this comment.
Wouldn't we miss an encoding error this way?
There was a problem hiding this comment.
You are completely right. I'll think about a solution and will update the PR shortly
The previous condition missed the return keyword.
|
Added a commit to fix a missing Would appreciate if you could quickly review it so that we can merge your feature 🙂 |
flying7eleven
left a comment
flying7eleven
left a comment
There was a problem hiding this comment.
🤦🏻 you are completely right, I guess that was my lack of golang knowledge (returning without the return keyword is a pattern of Rust)
|
I thought so 😅 |
2 participants
This PR combines two different things since the first one was mandatory for me for actually testing my changes:
arm64architecture.--jsonflag to thegit-team statuscommand. This prints out the same information as without this flag but in a machine-readable format.Happy to discuss the proposed changes 🥳