Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing services in demo, fix README files, add missing CSS for fediverse and remote flattr #434

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

richard67
Copy link
Contributor

@richard67 richard67 commented Oct 19, 2023

This pull request (PR) fixes several issues mainly caused by recently merged PRs.

  1. Add missing less file for the recently added "fediverse" (Mastodon) service so that buttom becomes visible (without that the button is white on white and so invisible). The colour has been taken from their site https://joinmastodon.org/ .
  2. Change icon of that service from "lock" to the Mastodon brand icon.
  3. Fix duplicate "data-services" row in parameter documentation which is caused by a merge conflict, see also 7c1f0f6#r127809094 .
  4. Fix wrong service name "tencent-weibo" instead of correct "tencent" in README files and demo/index.html - this seems to be an older issue.
  5. Add missing services to README files and list them in alphabetical order.
  6. Add missing services to first 3 examples in demo/index.html and use them in alphabetical order, except that the "internal" links for services "clipboard", "mail", "print" and "info" come as last.
  7. Synch the German README file with recent changes in the English one (https and example code).
  8. Remove "flattr" service as it has been discontinued, see PR Remove Flattr service shariff-backend-php#190 and the referred issue in the shariff-backend-php repository.

@richard67 richard67 changed the title Fix missing services in demo, fix README files and add missing CSS for fediverse Fix missing services in demo, fix README files, add missing CSS for fediverse and remote flattr Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant