Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vault/api module instead of vault #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

HnH
Copy link

@HnH HnH commented Jan 9, 2020

Purpose of this PR is to:

  1. Use the vault/api module, instead of vault itself.
  2. Update vault api lib version used in confita at the moment.
  3. Fix a situation with ambiguous import when a project requires both confita and vault/api modules, which happens now because confita locks vault version on v0.9.6 which depends on older api version.
go get github.com/hashicorp/vault/api: ambiguous import: found github.com/hashicorp/vault/api in multiple modules:
	github.com/hashicorp/vault v0.9.6 (/home/sergey/apps/go/pkg/mod/github.com/hashicorp/[email protected]/api)
	github.com/hashicorp/vault/api v1.0.4 (/home/sergey/apps/go/pkg/mod/github.com/hashicorp/vault/[email protected])

@HnH HnH requested a review from rogpeppe February 20, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant