Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slam add landmarks #268

Closed

Conversation

neuromechanist
Copy link
Member

Add lanmarks and crossrefs to NCIT, FMA and UBERON when available.

@neuromechanist
Copy link
Member Author

Looking at the changed files, it appears that only one file is changed, which should be the case. But the automated check throws the following error:

Multiple schemas of type library_schemas/slam/prerelease/HED_slam_1.0.0 were modified, and are not equal.
Only modify one source schema type at a time(mediawiki, xml, tsv), or modify all 3 at once.
Error: Validation failed for 'library_schemas/slam/prerelease/hedtsv/HED_slam_1.0.0/HED_slam_1.0.0_Tag.tsv'.

@VisLab
Copy link
Member

VisLab commented Oct 22, 2024

@neuromechanist The process is a work-in-progress. It appears that somewhere along the line the Mastoid-process tag was changed in the mediawiki in addition to the changes in the .tsv. Could you wait until the lang schema PR gets merged and the lang schema gets released? Then we can start with a fresh branch with the latest from master and go through the process together.

@VisLab
Copy link
Member

VisLab commented Oct 28, 2024

@neuromechanist Can you close this PR and make sure you have pulled the latest version of main then resubmit. I will then merge and do the verification locally and re-upload. I still have not been able to resolve why you are getting a conflict between the three formats, but the lang schema had the same issue. When I validate and resave the files locally, the problem goes away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants