-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exemplar tags #256
Add exemplar tags #256
Conversation
library_schemas/slam/prerelease/hedtsv/HED_slam_1.0.0/HED_slam_1.0.0_Tag.tsv
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first start. I am pretty sure that the links we will want to add will all be AnnotationProperty types (like has_dbxref) so we won't need any different infrastructure.
I have commented on the syntax problems above. After we finalize exactly which thing we will use, this will just need the syntax corrected.
Thanks Kay, I corrected the Annotations and added obo to the prefix table. |
library_schemas/slam/prerelease/hedtsv/HED_slam_1.0.0/HED_slam_1.0.0_Prefixes.tsv
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some circular or incorrect references and other syntax errors:
Head-landmark
lists its parent asAnatomical-landmarks
. It should beAnatomical-landmark
Torso-chest-landmark
also listsAnatomical-landmarks
as it parent.- HED tag names cannot have blanks or parentheses. By convention only first letter is capitalized.
Left-helix-tragus-junction
Right-helix-tragus-junction
Vertebra-promines
The stuff in parentheses should probably go in the description.
Addressed! |
I have added a couple of tags with references in the Annotation column.
I think there are some outstanding points:
has_dbxref
ordb_xref
for cross-referencing (or any other label)?has_dbxref
is defined here anddb_xref
is defined here.LHJ
andRHJ
? Many of them are quite well-known and handy to use