Fixed the XML for the testlib #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would probably be best to put it on the unit only rather than the unitClass or both? When validating it's just going to check if the default unit exists or not, it won't care at that point if it has invalid characters. It will check the invalid characters on the actual unit. Also just to note, this is a new case where "allowedCharacter" will now have a direct impact on a schema, rather than just normal validation of value classes. This isn't a problem for me, just confirming intent. |
|
Validation is failing because allowedCharacter is only applicable to value classes(in the current 8.3.0), but used on units and unit classes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The current version of the prelease of 8.3.0 does not validate because we are in the process of adding allowedCharacter support. A subsequent pull request will fix this @IanCa.