Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: Add opencost plugin #40

Merged
merged 1 commit into from
Jul 18, 2024
Merged

plugins: Add opencost plugin #40

merged 1 commit into from
Jul 18, 2024

Conversation

yolossn
Copy link
Contributor

@yolossn yolossn commented May 1, 2024

How to install opencost in cluster

  1. Install prometheus using helm

helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
helm install prom prometheus-community/kube-prometheus-stack

  1. Create a values.yaml
opencost:
  prometheus:
    internal:
      enabled: true
      namespaceName: default
      port: 9090
      serviceName: prom-kube-prometheus-stack-prometheus
  1. Install opencost

helm repo add opencost https://opencost.github.io/opencost-helm-chart
helm install -f values.yaml my-opencost opencost/opencost

Video.Project.2.mp4

@yolossn yolossn force-pushed the opencost_plugin branch 5 times, most recently from bc8bc6d to edd5a92 Compare May 13, 2024 20:48
@joaquimrocha joaquimrocha added this to the v0.24.0 milestone May 21, 2024
Copy link
Contributor

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. I also think it should be nice to link to the instructions of how to set up OpenCost.
This could be done in the settings view, and we should have some way to warn the user about the need to set up OpenCost. E.g. a link "Please set up" instead of the value or ..., but this link should only be visible on hover (I think the new table supports this more easily). When OpenCost is not available and it's not configured, I think we should have ! as the value. So users do not think the values are still loading.

opencost/src/settings.tsx Show resolved Hide resolved
opencost/src/settings.tsx Outdated Show resolved Hide resolved
opencost/src/settings.tsx Show resolved Hide resolved
opencost/src/settings.tsx Show resolved Hide resolved
opencost/src/settings.tsx Show resolved Hide resolved
opencost/package.json Outdated Show resolved Hide resolved
opencost/package.json Outdated Show resolved Hide resolved
opencost/src/settings.tsx Outdated Show resolved Hide resolved
opencost/src/settings.tsx Outdated Show resolved Hide resolved
@yolossn
Copy link
Contributor Author

yolossn commented Jul 16, 2024

Adding few screenshots for reference.
image
image
image
image
image
image
image

Copy link
Contributor

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found that the main.js is checked in, when it should not.
Also please rebase since there are now fixes in main for CI issues.

opencost/dist/main.js Outdated Show resolved Hide resolved
@yolossn yolossn force-pushed the opencost_plugin branch 2 times, most recently from 69041ce to add8937 Compare July 16, 2024 18:17
@yolossn
Copy link
Contributor Author

yolossn commented Jul 16, 2024

image
image
image

@yolossn yolossn force-pushed the opencost_plugin branch 2 times, most recently from a056a08 to 5197d68 Compare July 18, 2024 07:02
this patch adds opencost plugin

Signed-off-by: yolossn <[email protected]>
@joaquimrocha joaquimrocha merged commit 5ef4d58 into main Jul 18, 2024
7 checks passed
@joaquimrocha joaquimrocha deleted the opencost_plugin branch July 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants