WIP frontend: Fix KubeObject type and all its uses #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sniok
force-pushed
the
kube-type
branch
2 times, most recently
from
f0ee0f1
to
621b07d
Compare
Signed-off-by: Oleksandr Dubenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KubeObject currently resolves to any. So everywhere KubeObject was used there's no type safety.
This PR fixes the makeKubeObject function, it no longer returns any. After that fix there are billion type errors now and I'm going through all of them. As much as possible I try to change only types without any logic changes.