docs: Headlamp on eks with cognito as oidc provider #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashu8912
force-pushed
the
eks-cognito-docs
branch
3 times, most recently
from
f85f17f
to
e2b3fec
Compare
|
Hey @ashu8912 nice work. I'll get to testing/reviewing it in the next days. (ps. I made a few apps with Cognito back in the day, and now I'm thinking about them) |
illume
requested changes
May 10, 2024
There was a problem hiding this comment.
Hey hey.
I liked the tutorial, it seems to cover what's needed.
- Made some suggestions for your consideration. (I added some links to some, so maybe edit comment to easily copy the links if you want them.)
- I didn't run through the tutorial testing it yet. (I can do that after you have addressed these suggestions so I have a better understanding)
Signed-off-by: ashu8912 <[email protected]>
ashu8912
force-pushed
the
eks-cognito-docs
branch
from
e2b3fec
to
3fd11ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.