charts: Provide 3 options for oidc configuration

[knrt10]

Now users have 3 different way they can set oidc configuration

• Directly set values of respective config.oidc.clientID and others which inject them into ENV variable, to be used by args.
• Use external i.e. already created secret with the same keys as args.
• Use config.oidc.secret.create functionality to create secret and have them dynamically loaded into the headlamp deployment.

Fixes: #1897

Testing

Scenario 1

This is when user just want to use ENV variables directly.

• Set values of config.oidc. clientID, clientSecret, issuerURL, scopes in values.yaml and set config.oidc.secret as false
• Run helm template charts/headlamp

Scenario 2

This is when user wants to use external secret created by them

• Create a new secret with above config.oidc values. For reference check template/secret.yaml. Then create it in your k8s cluster using kubectl command.
• Set config.oidc.secret as false and set config.oidc.externalSecret as true and also the name of secret.
• Run helm template charts/headlamp

Scenario 3

This is when user want to use the secret created by headlamp

• Set values of config.oidc. clientID, clientSecret, issuerURL, scopes in values.yaml and set config.oidc.secret as true
• Run helm template charts/headlamp

[illume]

Nice one.

Could you please mention what testing was done in the PR description?

I see documentation inline, but perhaps this needs to be documented somewhere in docs/ as well?

Did you look at how the bitnami charts for redis/mongo/postgresql are done?
I see they use examples and document paramaters in detail https://github.com/bitnami/charts/blob/main/bitnami/postgresql/values.yaml#L1635
Also they have a values.schema.json https://github.com/bitnami/charts/blob/main/bitnami/postgresql/values.schema.json

[knrt10]

Thanks for the review. I did find the parama docs used by bitnami to be useful. Will do that and add these to the documentation someplace

[illume]

I added a separate issue for adding a json schema to the chart #1926 if that is out of scope for this PR.

[joaquimrocha]

Added a comment about some of the logic used. Can you also add the template tests for this?

[illume]

👍 thanks