-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin Store prerequisites #1907
base: main
Are you sure you want to change the base?
Conversation
@yolossn I guess you saw these app CI failures? https://github.com/headlamp-k8s/headlamp/actions/runs/8662622201/job/23754940075?pr=1907#step:5:237 They look like real failures. About some module missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thank you.
There's some error in the app CI job about a missing module.
I left a few notes...
Additionally,
- please add some tests? (maybe they could go in with the existing tests... but perhaps because they run quickly, and the existing tests are a bit clumbsy because they try to avoid a lot of extra installations, it would be better to have a separate set of tests for some of these commands using jest?)
- please update the README with the new commands next to the existing ones? Maybe add a section on how that binary is different.
e8eec01
to
9d72132
Compare
d676012
to
48518cf
Compare
d4e8afb
to
584b09d
Compare
this patch adds PluginManager class that has functions to install, update,uninstall and list plugins Signed-off-by: yolossn <[email protected]>
Signed-off-by: yolossn <[email protected]>
this patch adds PluginManagerEventListeners class that sets up the event handlers for the plugin manager events. Signed-off-by: yolossn <[email protected]>
this commit adds PluginManager class to handle plugin installation,update,uninstallation and listing, the class provides static methods for each operation and communicates to the electron app using the desktop API. the class also has a cancel function to cancel a running installation or update process. Signed-off-by: yolossn <[email protected]>
This patch adds the plugin management commands install,uninstall,update and list to the headlamp-plugin cli. Signed-off-by: yolossn <[email protected]>
This patch updates the send method to accept multiple arguments. This allows for more flexibility in sending data via IPC channels from renderer process to the main process Signed-off-by: yolossn <[email protected]>
A new
plugin-management.js
file has been introduced, responsible for handling plugin installation, listing, upgrades, and deletions. Additionally, therunCommand
function has been enhanced to support electron-node command, enabling seamless execution of Node commands within the Electron environment.