frontend: filter list views by default namespace #1710
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariusz Winnik <[email protected]>
tazo90
force-pushed
the
feat/750-filter-list-view-by-namespace
branch
from
acb81bb
to
a0fe387
Compare
joaquimrocha
requested changes
Feb 26, 2024
Comment on lines
+770
to
+774
| return streamResultsForCluster( | ||
| url(namespace, cluster, true), | ||
| { cb, errCb, cluster }, | ||
| queryParams | ||
| ); |
There was a problem hiding this comment.
We want by default to try to list in all namespaces, unless there are allowed namespaces set up. If checking all namespaces fails, we should check the default one for the cluster, but these changes just check the default one all the time, which is not what's desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue fixes #750 by allowing to filter cluster resources on the backend by using a globally defined default namespace.
It currently works with one namespace at a time, as that's what the Kubernetes API allows. If we want to support multiple namespaces, extra requests would be needed for each one.
Thanks to that we can limit results from API and reduce response size.
How to test: