Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: backend/pkg/plugins: Add CheckHeadlampPluginVersion #1624

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

illume
Copy link
Contributor

@illume illume commented Dec 20, 2023

For checking plugin version compatibility.

WIP: This should only fail when run in-cluster mode, not in app mode. Because those delivering an app with bundled plugins would consider this an error if the in-cluster app ran without plugins.

How to test?

  • there is a unit test
  • add an old plugin (less than 0.8.0-alpha.10), and the backend should fail to run with an error explaining the problem
  • it should NOT exit with an error when run in app mode
  • it SHOULD exit with an error when run in-cluster mode

The backend should fail when in-cluster mode.

# checkout the previous release and install an old plugin
git checkout 
cd plugins/examples/pod-counter/
npm i
npm start

# running the backend should fail because old plugin
cd ../../../
make run-backend

Test the app should not error:

# checkout the previous release and install an old plugin
git checkout 
cd plugins/examples/pod-counter/
npm i
npm start

# running the app should NOT fail because of an old plugin
cd ../../../
cd app
npm start

@illume illume marked this pull request as draft December 20, 2023 13:23
@illume illume force-pushed the plugins-compat branch 3 times, most recently from 54fa945 to fdacb79 Compare December 20, 2023 14:14
Copy link

Backend Code coverage changed from 56.6% to 57.1%. Change: .5% 😃.

Copy link

Backend Code coverage changed from 56.3% to 57.1%. Change: .8% 😃.

For checking plugin version compatibility.

Signed-off-by: René Dudfield <[email protected]>
@illume illume marked this pull request as ready for review December 20, 2023 14:25
@illume illume marked this pull request as draft December 20, 2023 14:26
@illume illume changed the title backend/pkg/plugins: Add checkHeadlampPluginVersion WIP: backend/pkg/plugins: Add checkHeadlampPluginVersion Dec 20, 2023
Copy link

Backend Code coverage changed from 56.7% to 57.1%. Change: .4% 😃.

@illume illume changed the title WIP: backend/pkg/plugins: Add checkHeadlampPluginVersion WIP: backend/pkg/plugins: Add CheckHeadlampPluginVersion Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant