Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Illogical behaviour with oidc #1897

Open
gecube opened this issue Apr 9, 2024 · 1 comment · May be fixed by #1920
Open

Illogical behaviour with oidc #1897

gecube opened this issue Apr 9, 2024 · 1 comment · May be fixed by #1920
Assignees
@knrt10
Labels
helm Related to helm and app-catalog

Comments

@gecube
Copy link

gecube commented Apr 9, 2024

Good day Sirs,

I am experimenting with your helm chart extensively.
And found the next thing. I can set up oidc settings with the config.oidc.secret.create: false value.
It leads to broken deployment as it expects the secret anyway. It is opaque behaviour as in fact as user I want to have three options:

  • put oidc settings and inject them like ENV variables directly from deployment (like for debug purposes)
  • use external secret precreated by means of any possible solution (external-secrets operator, vault, I created the secret in k8s myself etc.) and give me an option to select this secret name
  • create the secret inside of helm chart and pass it to the deployment with the option to reload deployment in case of changing the secret (add sha annotation in labels for the deployment)
  • make the options exclusive to each other. Now I can set up oidc settings and not create the secret, which does not make sense...

I think good example could be bitnami charts for redis/mongo/postgresql, where it is obvious what to put into values.yaml
@gecube gecube changed the title Illogical behvaiour with oicd Illogical behaviour with oicd Apr 9, 2024
@illume illume added the helm Related to helm and app-catalog label Apr 9, 2024
@gecube gecube changed the title Illogical behaviour with oicd Illogical behaviour with oidc Apr 10, 2024
@knrt10
Copy link
Contributor

knrt10 commented Apr 22, 2024

Thank you for the detailed issue @gecube. Fixing this

knrt10 added a commit that referenced this issue Apr 22, 2024
@knrt10
charts: Provide 3 options for oidc configuration
71a6828 
Now users have 3 different way they can set oidc configuration

- Directly set values of respective config.oidc.clientID and others
  which inject them into ENV variable, to be used by args.
- Use external i.e. already created secret with the same keys as args.
- Use config.oidc.secret.create functionality to create secret and have
  them dynamically loaded into the headlamp deployment.

Fixes: #1897
Signed-off-by: Kautilya Tripathi <[email protected]>
@knrt10 knrt10 linked a pull request Apr 22, 2024 that will close this issue
Open
@illume illume mentioned this issue Apr 24, 2024
Open
knrt10 added a commit that referenced this issue Apr 29, 2024
@knrt10
charts: Provide 3 options for oidc configuration
715e8c3 
Now users have 3 different way they can set oidc configuration

- Directly set values of respective config.oidc.clientID and others
  which inject them into ENV variable, to be used by args.
- Use external i.e. already created secret with the same keys as args.
- Use config.oidc.secret.create functionality to create secret and have
  them dynamically loaded into the headlamp deployment.

Fixes: #1897
Signed-off-by: Kautilya Tripathi <[email protected]>
knrt10 added a commit that referenced this issue May 14, 2024
@knrt10
charts: Provide 3 options for oidc configuration
1dc0920 
Now users have 3 different way they can set oidc configuration

- Directly set values of respective config.oidc.clientID and others
  which inject them into ENV variable, to be used by args.
- Use external i.e. already created secret with the same keys as args.
- Use config.oidc.secret.create functionality to create secret and have
  them dynamically loaded into the headlamp deployment.

Fixes: #1897
Signed-off-by: Kautilya Tripathi <[email protected]>
knrt10 added a commit that referenced this issue May 20, 2024
@knrt10
charts: Provide 3 options for oidc configuration
f7bf857 
Now users have 3 different way they can set oidc configuration

- Directly set values of respective config.oidc.clientID and others
  which inject them into ENV variable, to be used by args.
- Use external i.e. already created secret with the same keys as args.
- Use config.oidc.secret.create functionality to create secret and have
  them dynamically loaded into the headlamp deployment.

Fixes: #1897
Signed-off-by: Kautilya Tripathi <[email protected]>
knrt10 added a commit that referenced this issue May 22, 2024
@knrt10
charts: Provide 3 options for oidc configuration
603c20a 
Now users have 3 different way they can set oidc configuration

- Directly set values of respective config.oidc.clientID and others
  which inject them into ENV variable, to be used by args.
- Use external i.e. already created secret with the same keys as args.
- Use config.oidc.secret.create functionality to create secret and have
  them dynamically loaded into the headlamp deployment.

Fixes: #1897
Signed-off-by: Kautilya Tripathi <[email protected]>
knrt10 added a commit that referenced this issue May 22, 2024
@knrt10
charts: Provide 3 options for oidc configuration
d687cc8 
Now users have 3 different way they can set oidc configuration

- Directly set values of respective config.oidc.clientID and others
  which inject them into ENV variable, to be used by args.
- Use external i.e. already created secret with the same keys as args.
- Use config.oidc.secret.create functionality to create secret and have
  them dynamically loaded into the headlamp deployment.

Fixes: #1897
Signed-off-by: Kautilya Tripathi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knrt10 knrt10

Labels
helm Related to helm and app-catalog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

charts: Provide 3 options for oidc configuration headlamp-k8s/headlamp
3 participants
@illume @gecube @knrt10