Skip to content

Commit

Permalink
frontend: common: Remove Logviewer Terminal from common
Browse files Browse the repository at this point in the history
Because they are not used in many modules, and so they
should not be loaded all the time by putting them in the
common/index.

Additionally, this means that the code is only loaded when
the pod details route is loaded.

Signed-off-by: René Dudfield <[email protected]>
  • Loading branch information
illume committed May 7, 2024
1 parent b7570fd commit d781b47
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 2 additions & 2 deletions frontend/src/components/common/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ const avoidCheck = [
'ActionsNotifier',
'AlertNotification',
'ErrorBoundary',
'LogViewer',
'Terminal',
];

const checkExports = [
Expand All @@ -27,7 +29,6 @@ const checkExports = [
'LabelListItem',
'Link',
'Loader',
'LogViewer',
'NamespacesAutocomplete',
'NameValueTable',
'Resource',
Expand All @@ -37,7 +38,6 @@ const checkExports = [
'ShowHideLabel',
'SimpleTable',
'Tabs',
'Terminal',
'TileChart',
'TimezoneSelect',
'Tooltip',
Expand Down
3 changes: 0 additions & 3 deletions frontend/src/components/common/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export * from './Link';
export { default as Link } from './Link';
export * from './Loader';
export { default as Loader } from './Loader';
export * from './LogViewer';
export * from './NameValueTable';
export { default as NameValueTable } from './NameValueTable';
export * from './ObjectEventList';
Expand All @@ -34,8 +33,6 @@ export * from './SimpleTable';
export { default as SimpleTable } from './SimpleTable';
export * from './Tabs';
export { default as Tabs } from './Tabs';
export * from './Terminal';
export { default as Terminal } from './Terminal';
export * from './TileChart';
export { default as TileChart } from './TileChart';
export * from './TimezoneSelect';
Expand Down

0 comments on commit d781b47

Please sign in to comment.