New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add total price to label and location pages #722
base: main
Are you sure you want to change the base?
Conversation
* bump all deps * run code-gen
…t#506) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…t#508) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ay-kot#451) * Fixed 3 places where API URLs were not constructed by function route(path, params). * autofix --------- Co-authored-by: Hayden <[email protected]>
* formatting * slimdown locations page * update location/labels * fix dependency issues * fix type generator * cleanup unused variables
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* add multiple new currencies * add multiple new currencies * remove duplicate yen
…port k… (hay-kot#526) * add support for create + add more for all create modals and support keyboard bindings * listen for esc to close modals
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…busting (hay-kot#527) * rough implementation of WS based event system for server side notifications of mutation * fix test construction * fix deadlock on event bus * disable linter error * add item mutation events * remove old event bus code * refactor event system to use composables * refresh items table when new item is added * fix create form errors * cleanup unnecessary calls * fix importer erorrs + limit fn calls on import
* Added currencies XAG and XAU to currency.ts I added XAG and XAU for myself and others who prefer to measure value with something of substance. Review the ISO 4217 standard to view a full list of official currency codes including the ones I have added. https://www.iso.org/iso-4217-currency-codes.html https://en.wikipedia.org/wiki/ISO_4217 Example: https://www.xe.com/currencyconverter/convert/?Amount=100&From=XAG&To=USD API for exchange rates: https://openexchangerates.org/ * Added field values xag and xau to group.go * Update group.go
* fix https connection * explicity dependency
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ay-kot#676) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…kot#673) * feat: show quantity in card view if quantity == 0 (hay-kot#672) * Update frontend/components/Item/Card.vue --------- Co-authored-by: bee-eater <[email protected]> Co-authored-by: Hayden <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Quoing <[email protected]>
* basic currency service for loading at runtime * api endpoint for currencies * sort slice before return * remove currency validation * validate using currency service * implement selecting dynamic currency options * bump go version * fix type definition * specify explicit type * change go versions * proper types for assetId * log/return currency error * make case insensative * use ToUpper instead * feat: adding new currencies (hay-kot#715) * fix: task swag (hay-kot#710) Co-authored-by: Quoing <[email protected]> * [feat] Adding new currencies --------- Co-authored-by: quoing <[email protected]> Co-authored-by: Quoing <[email protected]> Co-authored-by: Bradley <[email protected]> * remove ts file and consoldate new values into json * move flag to options namespace * add env config for currencies * basic documentaion * remove in sync test --------- Co-authored-by: quoing <[email protected]> Co-authored-by: Quoing <[email protected]> Co-authored-by: Bradley <[email protected]>
Co-authored-by: zebrapurring <>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…-kot#668) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…0.17.0 (hay-kot#717) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
A way to build onto this could be adding the price directly on the item cards, and taking into consideration if the item is sold or not. However, especially for having the price on the cards, some people might not want these additions. So it might be a good idea to add them, but as an option - although this would probably be a fair bit larger of a change so more than I could personally cobble together in a language I've hardly touched. |
b22ff27
to
d9497bd
Compare
Any thoughts @hay-kot? |
Hey! I do want to merge this. I still need to work through your approach, I think there may be some better ways to do this. I will try to get through the PR this week or next. |
What type of PR is this?
What this PR does / why we need it:
It adds an indicator to the /label and /location pages to show the overall purchase price.
This is a modified version of #638, where calculation is performed on the backend, instead of the frontend, as requested by @hay-kot.
For locations it includes child locations.
Location
Label
Changed files:
Special notes for your reviewer:
I haven't used golang before, there's no errors and it works but it might not be done to the best way.
Testing
Labels
Locations
Release Notes