DEV-1587: fix collection edit modal bugs

[carylwyatt]

'new collection' modal trigger user always anonymous

current behavior

From mb landing page, when a user clicks "New Collection" (from the collection toolbar under "Featured collections" and above the listing of collections), the New Collection (also sometimes says Edit Collection, depending on the situation) modal appears. Regardless of login status, this modal tells the user their new collection will be temporary unless they log in (even if the user is already logged in).

the fix

The modal already had a userIsAnonymous variable but it wasn't getting set in this context (via the results toolbar in mb) so the change in UI never happened. (To be fair, this variable is getting set when you create a collection via ls collection toolbar). Instead of relying on passing down the variable from the ls or mb XML, I'm using the HT global variable that holds info about login status: HT.login_status.logged_in.

to test

On dev-3, click the "New Collection" button before logging in and see the usual "This collection will be temporary" message. Log in, then click the button again. The message should not appear and you should have the ability to make the collection public.

modal allows form submit without collection name (which leads to Application Error)

current behavior

If you create a new collection but don't give it a name in the form, you can still submit the form (via "Save Changes" button). After the form is submitted, the application can't redirect you to your collection or list of collections because you didn't supply any information, so you'll get an "Application Error" page instead.

the fix

I added form validation to the "Collection name" field in the New Collection form.

to test

On dev-3, click the "New Collection" button and without filling out any fields, click "Save Changes" to submit the form. You should now get two error messages: one under the Collection Name field and another in the footer of the modal letting you know that you need to fix something and try again.

[moseshll]

Both the logged-in behavior and modal validation fix worked for me.

I do not like the wording of the error message, however: "The form did not submit. Please add a collection name and resubmit the form." On the logic that "form" is a technical term, and that there is no button named "Submit", maybe something like "The collection could not be saved [or, created]. Please add a collection name [and try again]."

[carylwyatt]

Thanks for your suggestion, @moseshll! I updated the error message with your text.

[moseshll]

All looks now to be in excellent shape. APPROVE