Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker CLI plugin RFC #164

Merged
merged 1 commit into from
May 15, 2024
Merged

Docker CLI plugin RFC #164

merged 1 commit into from
May 15, 2024

Conversation

daniel-chambers
Copy link
Contributor

@daniel-chambers daniel-chambers commented May 9, 2024 •
edited

@daniel-chambers daniel-chambers self-assigned this May 9, 2024
SandeepSamba
SandeepSamba approved these changes May 13, 2024
View reviewed changes
Copy link

@SandeepSamba SandeepSamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from ddn CLI end. It would be great if we can get this validated from the connector author end as well.

@daniel-chambers daniel-chambers merged commit 24a15af into main May 15, 2024
@daniel-chambers daniel-chambers deleted the daniel/rfc-docker-cli-plugin branch May 15, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandeepSamba SandeepSamba SandeepSamba approved these changes

Assignees

@daniel-chambers daniel-chambers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daniel-chambers @SandeepSamba