Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testsuite: Add process-fork-wait test #179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

testsuite: Add process-fork-wait test #179

wants to merge 2 commits into from

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented May 31, 2020

This test verifies that the use_process_jobs feature works as
advertised. Specifically: on Windows waitForProcess should not return
until all processes created by the child (including those created with
fork) have exited if use_process_jobs is enabled.

Frankly, this test should have been added long ago.

@bgamari bgamari force-pushed the test-fork-wait branch 3 times, most recently from 2916537 to 1853eb4 Compare May 31, 2020 21:49
snoyberg
snoyberg approved these changes Jun 1, 2020
View reviewed changes
Copy link
Collaborator

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these kinds of changes which only affect GHC, I'd rather defer to you to do the merge yourself, so that (1) I don't block GHC dev and (2) it fits into the GHC dev cycle.

@bgamari
Copy link
Contributor Author

bgamari commented Jun 1, 2020

Sure, I would be happy to handle it myself. Thanks for the quick feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgamari @snoyberg