Support for 9.10 #4233
Merged
Support for 9.10 #4233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes supports for all plugins, other than formatters and hlint. We need ghc-exactprint and retrie release before merging this.
wz1000
requested review from
michaelpj,
fendor,
pepeiborra,
konn,
santiweight,
joyfulmantis,
July541 and
ozkutuk
as code owners
|
If anyone wants to help, chasing up any of the allow-newers would be helpful (get upstream to release/make a revision). |
|
I've revised the |
|
Somehow the build is failing on macos with a weird linker error? |
michaelpj
added a commit
that referenced
this pull request
Jun 12, 2024
This is an attempt to isolate changes from #4233 in order to reproduce the mac build failure.
Closed
|
|
This reverts commit 7142686.
|
The plugin doesn't compile and it's not 100% obvious how to fix it, so reverting to add later. |
|
I made a GHC issue for the linker problem: https://gitlab.haskell.org/ghc/ghc/-/issues/24982 It's also reproducible if we just bump the index-state: #4315 |
michaelpj
approved these changes
Jun 13, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes supports for all plugins, other than formatters and hlint.
We need ghc-exactprint and retrie release before landing this.