Get rid of an incomplete pattern match #247
Conversation
| @@ -202,7 +202,7 @@ Extract the string that comes before the module declaration... | |||
| > . table_text | |||
|
|
|||
| > lib_content lib_text | |||
| > = let (pre,_drop_me : post) = break (== "fakeimport DATA") $ lines lib_text | |||
| > = let (pre,post) = break (== "fakeimport DATA") $ lines lib_text | |||
There was a problem hiding this comment.
Should we make such a change? I think it is hurting code comprehensibility more than helping it.
The current formulation makes clear that the _drop_me : post match MUST succeed, even if GHC does not see it.
The new formulation clouds this insight.
So, I am against such a change.
There was a problem hiding this comment.
Yes it would be better to add an explicit pattern match with an error .... It would be even better to try to use NonEmpty.
There was a problem hiding this comment.
NonEmpty is available from base-compat for old GHC versions back to 7.0 (base-4.3), so that would not be a problem for keeping all currently supported GHC versions.
|
Fixed the incomplete match warnings in #281. |
|
I'd argue that #281 didn't fix anything, but merely hid the warnings. |
|
Well, the problem with these warnings is that you cannot switch them on a case-by-case basis.
For this issue, we are in case 3a, but unfortunately GHC only allows us to switch off the warning globally. |
No description provided.