Make Name a newtype #223
Merged
Make Name a newtype #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I am getting somewhere with this now |
|
It builds, but the tests aren't passing. Broke off #296 in part to help bisect. |
Ericson2314
force-pushed
the
name-newtype
branch
2 times, most recently
from
c21c85f
to
6423350
Compare
sgraf812
reviewed
Sep 24, 2024
sgraf812
reviewed
Sep 24, 2024
Ericson2314
force-pushed
the
name-newtype
branch
from
7dc78a9
to
71bfbaf
Compare
Co-authored-by: Sebastian Graf <[email protected]>
Ericson2314
force-pushed
the
name-newtype
branch
from
71bfbaf
to
e5eadf1
Compare
|
OK @sgraf812! Thanks again. Want to give it a final review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GLR backend has me stuck, but I think I got the rest.
Depends on #296