Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Data.Array.ST instead of Data.Array.ST.Safe #970

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Import Data.Array.ST instead of Data.Array.ST.Safe #970

wants to merge 1 commit into from

Conversation

konsumlamm
Copy link
Contributor

Data.Array.ST exports the same things as Data.Array.ST.Safe, the latter was just added as a migration strategy. The *.Safe modules in array might get deprecated in the future, see https://gitlab.haskell.org/ghc/packages/array/-/issues/11.

@treeowl
Copy link
Contributor

treeowl commented Sep 27, 2023

There seems to be an incorrect assumption somewhere; CI is failing.

@konsumlamm
Copy link
Contributor Author

Yes, Data.Array.ST.Safe is marked as Trustworthy, while Data.Array.ST is not. This makes it fail, because Data.Graph is marked as Safe.

The next step would be to mark Data.Array.ST as Trustworthy.

@konsumlamm konsumlamm marked this pull request as draft September 27, 2023 13:46
@meooow25
Copy link
Contributor

meooow25 commented Oct 1, 2023

On Hackage I can see that Data.Array.ST is "Safe-Inferred" 0.5.5.0 onwards. This is included in GHC 9.6. Doesn't that mean it should compile fine without any changes with GHC 9.6 and above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konsumlamm @treeowl @meooow25