Inline the common case of balance functions#1056
Merged
meooow25 merged 2 commits intohaskell:masterfrom Jan 12, 2025
Merged
Conversation
Contributor
Author
|
@treeowl would you like to take a look at this? |
For Set and Map, inline the common case of balance, balanceL, balanceR, as explained in the "Inlining balance" note. A decrease in running time of 10-30% is seen in benchmarks for insert, delete, union, and more.
meooow25
force-pushed
the
balance-partial-inline
branch
from
240d0e7 to
d65ef95
Compare
Contributor
Author
|
Rebased and updated benchmarks. I'll merge this soon so that I can compare against this for #1073. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1053
Benchmarks, using GHC 9.10.1:
Set:
Expand
Map:
Expand
Set operations, Set:
Expand
Set operations, Map:
Expand