On Windows Distribution.Compat.CopyFile.copyFile is System.Directory.copyFileWithMetadata #11438
+17
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
reviewed
Jan 17, 2026
Bodigrim
force-pushed
the
clean-up-copyFile-on-Windows
branch
from
473178f to
f448484
Compare
geekosaur
approved these changes
Jan 17, 2026
Bodigrim
force-pushed
the
clean-up-copyFile-on-Windows
branch
from
f448484 to
c518413
Compare
…copyFileWithMetadata As noticed in #11437, the implementation of `Distribution.Compat.CopyFile.copyFile` on Windows replicates `System.Directory.copyFileWithMetadata`. Given that we already require `directory >= 1.2.7` and `copyFileWithMetadata` was introduced in `directory-1.2.6.0`, we can go ahead and reuse it.
Bodigrim
force-pushed
the
clean-up-copyFile-on-Windows
branch
from
c518413 to
2ef1d45
Compare
ffaf1
approved these changes
Jan 17, 2026
mergify
bot
added
the
ready and waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed in #11437, the implementation of
Distribution.Compat.CopyFile.copyFileon Windows replicatesSystem.Directory.copyFileWithMetadata. Given that we already requiredirectory >= 1.2.7andcopyFileWithMetadatawas introduced indirectory-1.2.6.0, we can go ahead and reuse it.Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: