Clean up Distribution.Compat.GetShortPathName #11431
Open
+18
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
force-pushed
the
clean-up-Distribution.Compat.GetShortPathName
branch
from
cd91dc2 to
6cd6b31
Compare
geekosaur
approved these changes
Jan 17, 2026
Mikolaj
approved these changes
Jan 17, 2026
Member
Mikolaj
left a comment
Mikolaj
left a comment
There was a problem hiding this comment.
I wonder who uses it and what for but at least we don't have to implement it now! :)
Collaborator
|
We may have to keep it around forever. Even if autoconf itself has been bulletproofed, there's no guarantee whatsoever that people's additions to their configure scripts are properly quoted. |
Collaborator
|
And IIRC exhibit A there is ghc. |
Bodigrim
added
merge me
mergify
bot
added
the
ready and waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: