Skip to content

validate dependabot configuration #10271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

geekosaur
Copy link
Collaborator

Borrowed from Ubuntu
(ubuntu/authd@3f9df8f)

Sadly, this won't check our existing config unless I make a dummy update.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). (only matters on master)

@geekosaur geekosaur force-pushed the dependabot-update branch 2 times, most recently from 93ff8af to dbf2387 Compare August 22, 2024 04:05
@geekosaur
Copy link
Collaborator Author

Does anyone know what the whitespace check is upset about? I don't see any lines with extra spaces or tabs. (I think.)

@ffaf1
Copy link
Collaborator

ffaf1 commented Aug 22, 2024

File not ending with \n?

@geekosaur
Copy link
Collaborator Author

Looks like it.

@geekosaur geekosaur force-pushed the dependabot-update branch 7 times, most recently from cbfb33a to e1b6bff Compare August 22, 2024 07:44
@geekosaur
Copy link
Collaborator Author

Okay, I've finally got this doing what it should be. The original one wanted extra permissions I couldn't figure out how to grant, but I don't think we want or need what it wanted to do (add/update a comment, on top of the job success/failure indication). I've also verified that it succeeds when it should and fails when it should.

Unfortunately, it's not answering the question that led me to make this PR: why didn't dependabot notify us of the updated actions when it's configured to do so?

Copy link
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@ulysses4ever
Copy link
Collaborator

Unfortunately, it's not answering the question that led me to make this PR: why didn't dependabot notify us of the updated actions when it's configured to do so?

Indeed. I hoped something from the relevant settings page may be the reason, but it doesn't look like it https://github.com/haskell/cabal/settings/security_analysis

Quick google search also doesn't bring any insights.

@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Aug 22, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Aug 24, 2024
Borrowed from Ubuntu
(ubuntu/authd@3f9df8f)

Sadly, this won't check our existing config unless I make a dummy
update.
@Mikolaj Mikolaj force-pushed the dependabot-update branch from e1b6bff to 770ceb3 Compare August 24, 2024 18:03
@mergify mergify bot merged commit 9b3ce92 into haskell:master Aug 24, 2024
50 checks passed
@geekosaur geekosaur deleted the dependabot-update branch September 3, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants