Backport: Implement instance Data (#614) #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh. A |
* Add functionality for toConstr * Other instances fixed * Move test * test passes * Add gshow tests * Typo * Add explicit string test * instance Data: implement gunfold and dataTypeOf * instance Data: fix tests * Fix emulated builds * Restore derived instance Data ShortByteString * Add instance Generic ShortByteString * Review suggestions --------- Co-authored-by: Colton Clemmer <[email protected]> (cherry picked from commit 1b9e6ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here for an illustration of how this differs from the original patch.