Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use primops for unaligned writes when possible #645

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

clyring
Copy link
Member

@clyring clyring commented Jan 17, 2024

I'm in no rush to land this. The "right" CPP condition won't work until upstream bumps their version numbers and anyway it might be nice to let the other implementations from #587 get tested more widely in 9.10.1-alpha1 first.

@clyring clyring added this to the 0.12.1.0 milestone Jan 30, 2024
@clyring
Copy link
Member Author

clyring commented Jan 30, 2024

Since it looks like ghc-9.8.2 will probably be released no later than ghc-9.10-alpha1 I guess there's no point in waiting with this one. I did verify that everything worked as expected (and with no warnings) with a recent-ish ghc HEAD before I changed the condition to MIN_VERSION_base(4,20,0).

@Bodigrim Bodigrim merged commit 44375fa into haskell:master Jan 30, 2024
24 of 25 checks passed
clyring added a commit that referenced this pull request Feb 5, 2024
* Use primops for unaligned writes when possible

* Check MIN_VERSION_base instead of __GLASGOW_HASKELL__

(cherry picked from commit 44375fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants