Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eta-expand Builder.Internal.empty #616

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Eta-expand Builder.Internal.empty #616

merged 1 commit into from
Sep 27, 2023

Conversation

clyring
Copy link
Member

@clyring clyring commented Sep 27, 2023

Bodigrim
Bodigrim approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, feel free to merge once TODO is resolved.

@clyring
Copy link
Member Author

clyring commented Sep 27, 2023

The TODO has been there for close to a decade; I don't feel any sudden hurry to resolve it.

@Bodigrim
Copy link
Contributor

Sorry, that's why reviewing from smartphone at 2am is not the wisest idea :)

@Bodigrim Bodigrim added this to the 0.12.1.0 milestone Sep 27, 2023
@Bodigrim Bodigrim merged commit 750dac3 into haskell:master Sep 27, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bodigrim Bodigrim Bodigrim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@clyring @Bodigrim