Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Data.ByteString.Short.Internal.BA #615

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

sol
Copy link
Member

@sol sol commented Sep 25, 2023

Data.ByteString.Short.Internal defines:

data BA = BA# ByteArray#

This type is equivalent to ByteArray from Data.Array.Byte, which is already used in Data.ByteString.Short.Internal.

This PR removes the BA data type in favor of ByteArray.

Copy link
Member

@clyring clyring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections here. Did you also want to give the same treatment to MBA/MutableByteArray?

@sol
Copy link
Member Author

sol commented Sep 27, 2023

Did you also want to give the same treatment to MBA/MutableByteArray?

Yes, I'll do a follow-up once this PR is merged.

@Bodigrim Bodigrim merged commit 2e2e5ca into haskell:master Sep 27, 2023
24 checks passed
@sol sol deleted the remove-ba branch September 27, 2023 01:52
sol added a commit to sol/bytestring that referenced this pull request Sep 27, 2023
sol added a commit to sol/bytestring that referenced this pull request Sep 27, 2023
@sol
Copy link
Member Author

sol commented Sep 27, 2023

Did you also want to give the same treatment to MBA/MutableByteArray?

Yes, I'll do a follow-up once this PR is merged.

#617

@clyring clyring added this to the 0.12.1.0 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants