-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete cabal.project #613
Delete cabal.project #613
Conversation
It seems to no longer do anything useful, and it also prevents CI from detecting that include/bytestring-cpp-macros.h was not getting picked up by `cabal sdist`.
In particular, this ensures that `cabal sdist` grabs it.
The cabal package description docs do not provide me much clarity on the relevant-looking package description fields
This doesn't appear to be true? Or is it a fluke that this appears to work for me?
These macros are probably not very useful to expose to downstream users. Maybe I should just use |
It does not harm, better be safe than sorry ;) |
The cabal documentation claims as a pre-requisite for its usability "when compiling the package itself." It's unclear if this is really true, but there is no harm done in adding bytestring-cpp-macros.h there just in case.
CI seems to say there is, in fact, harm done. |
I see this in the
It seems that cabal-install believes |
It seems this macro is never visible in Haskell code. But with real unaligned primops in the near future, it doesn't seem worth messing with.
The windows jobs were subtly broken by haskell#613, which caused the build products to live in bytestring-*/dist-newstyle instead of dist-newstyle. This didn't appear to break immediately because we restored cached stuff in dist-newstyle including stale executables. It wasn't until a week of inactivity caused our cache to expire that the breakage became appropriately obvious. I don't really understand what went wrong with the centos job; I just borrowed the workaround from haskell/text#541.
The windows jobs were subtly broken by #613, which caused the build products to live in bytestring-*/dist-newstyle instead of dist-newstyle. This didn't appear to break immediately because we restored cached stuff in dist-newstyle including stale executables. It wasn't until a week of inactivity caused our cache to expire that the breakage became appropriately obvious. I don't really understand what went wrong with the centos job; I just borrowed the workaround from haskell/text#541.
The windows jobs were subtly broken by #613, which caused the build products to live in bytestring-*/dist-newstyle instead of dist-newstyle. This didn't appear to break immediately because we restored cached stuff in dist-newstyle including stale executables. It wasn't until a week of inactivity caused our cache to expire that the breakage became appropriately obvious. I don't really understand what went wrong with the centos job; I just borrowed the workaround from haskell/text#541. (cherry picked from commit bf5f5da)
It seems to no longer do anything useful, and it also prevents CI from detecting that include/bytestring-cpp-macros.h was not getting picked up by
cabal sdist
.