Avoid __builtin_ctzll on some platforms #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
approved these changes
Aug 3, 2023
clyring
added a commit
that referenced
this pull request
Aug 4, 2023
juhp
reviewed
Aug 8, 2023
| @@ -50,6 +50,7 @@ SUCH DAMAGE. | |||
| #endif | |||
|
|
|||
| #include <MachDeps.h> | |||
| #include "Rts.h" | |||
There was a problem hiding this comment.
This seems to break x86_64 on Fedora for me... booting 9.4.6 with either 9.2.8 or 9.4.5:
In file included from /usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/rts-1.0.2/include/Rts.h:235,
from libraries/bytestring/cbits/is-valid-utf8.c:53:0: error:
/usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/rts-1.0.2/include/rts/OSThreads.h:38:5: error:
error: unknown type name ‘clockid_t’
38 | clockid_t timeout_clk;
| ^~~~~~~~~
|
38 | clockid_t timeout_clk;
| ^
There was a problem hiding this comment.
Looks to me like that #include should be conditional somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #601.
I haven't worked out how to reproduce the problem (outside of GHC's CI), but that doesn't seem critical. (And this patch does fix the problem there.)