Deprecate memcpy and memset #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with ghc-9.8, copyBytes and fillBytes from base will use dedicated primops that ghc can sometimes emit better code for if the length is known and small enough. We should take advantage of this rather than using a foreign call that ghc won't recognize. See also https://gitlab.haskell.org/ghc/ghc/-/merge_requests/9629
Bodigrim
reviewed
Jun 5, 2023
Data/ByteString/Internal/Type.hs
Outdated
| @@ -1019,27 +1020,22 @@ memcmp p q s = c_memcmp p q (fromIntegral s) | |||
| foreign import ccall unsafe "string.h memcpy" c_memcpy | |||
| :: Ptr Word8 -> Ptr Word8 -> CSize -> IO (Ptr Word8) | |||
|
|
|||
| {-# DEPRECATED memcpy "Use Foreign.Marshal.Utils.copyBytes instead" #-} | |||
| -- | deprecated since @bytestring-0.11.5.0@ | |||
| memcpy :: Ptr Word8 -> Ptr Word8 -> Int -> IO () | |||
| memcpy p q s = void $ c_memcpy p q (fromIntegral s) | |||
There was a problem hiding this comment.
Shall we actually implement it via copyBytes and scrap foreign import?
Bodigrim
approved these changes
Jun 11, 2023
clyring
added a commit
that referenced
this pull request
Jun 13, 2023
* Deprecate memcpy and memset Starting with ghc-9.8, copyBytes and fillBytes from base will use dedicated primops that ghc can sometimes emit better code for if the length is known and small enough. We should take advantage of this rather than using a foreign call that ghc won't recognize. See also https://gitlab.haskell.org/ghc/ghc/-/merge_requests/9629 * clean up some fromIntegral calls * remove foreign import for memcpy
This was referenced Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with ghc-9.8,
copyBytesandfillBytesfrombasewill use dedicated primops that ghc can sometimes emit better code for if the length is known and small enough. We should take advantage of this rather than using a foreign call that ghc won't recognize.See also https://gitlab.haskell.org/ghc/ghc/-/merge_requests/9629