Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exclusion of operation IDs #158

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Improve exclusion of operation IDs #158

merged 2 commits into from
Jul 27, 2023

Conversation

maxb
Copy link
Contributor

@maxb maxb commented Jul 27, 2023

Add enterprise-stub as an excluded prefix.

Refactor the exclusion so the exclusion list only needs to be maintained
in one Handlebars template.

(The actual OpenAPI spec sync to make use of this will follow in
a separate PR, to avoid conflicts, and avoid mixing human-authored and
autogenerated changes too much.)

Add enterprise-stub as an excluded prefix.

Refactor the exclusion so the exclusion list only needs to be maintained
in one Handlebars template.

(The actual OpenAPI spec sync to make use of this will follow in
a separate PR, to avoid conflicts, and avoid mixing human-authored and
autogenerated changes too much.)
@maxb maxb requested a review from a team July 27, 2023 13:35
@maxb
Copy link
Contributor Author

maxb commented Jul 27, 2023

Some of the whitespace control in this PR is a bit inconsistent in appearance, because I had to work around jknack/handlebars.java#1071

@maxb
Copy link
Contributor Author

maxb commented Jul 27, 2023

This PR will have a red check until #156 is merged to main, and main merged into this branch.

Copy link
Collaborator

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@averche averche merged commit 7c838da into hashicorp:main Jul 27, 2023
3 checks passed
@maxb maxb deleted the operationid-exclusion-improvement branch July 27, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants