very minor fixups for test convenience #37555
Open
+62
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildwonkey
added
the
no-changelog-needed
mildwonkey
force-pushed
the
mildwonkey/actions-references
branch
from
a4d17b4 to
e6dc552
Compare
mildwonkey
force-pushed
the
mildwonkey/actions-references
branch
from
fdbd5aa to
25d6d70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started life as an exploration of depends_on inside action declarations. All that's left is a couple of minor changes that were inspired while writing tests (that no longer exist) - the provider mock action invocation methods weren't quite hooked together correctly (returning nil responses instead of empty responses) and I found a panic that I don't expect will happen in real use, but it seemed worth guarding against.