Skip to content

Conversation

xingjiu
Copy link
Contributor

@xingjiu xingjiu commented Apr 17, 2025

Fixes #36897

This PR addresses [Terraform Issue #36897]. The core implementation was previously contributed to OpenTofu PR #2675 and is adapted here to fit Terraform's codebase.

Target Release

1.13.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@xingjiu xingjiu requested a review from a team as a code owner April 17, 2025 07:12
Copy link

hashicorp-cla-app bot commented Apr 17, 2025

CLA assistant check
All committers have signed the CLA.

@jbardin
Copy link
Member

jbardin commented Apr 17, 2025

@xiaozhu36 per codeowners

@xiehan
Copy link
Member

xiehan commented Jun 24, 2025

@xiaozhu36 Friendly reminder to please review this backend PR. If we want to include this in the 1.13 release, it needs to be approved and merged within the next couple of weeks.

@xiaozhu36
Copy link
Contributor

@xiehan I have reviewed the PR and there is no problem.

@xiehan
Copy link
Member

xiehan commented Jun 26, 2025

Great! @xingjiu Could you rebase your PR?

@xiehan
Copy link
Member

xiehan commented Jul 3, 2025

@xingjiu If you want this to be included in 1.13.0, it needs to be merged by next Tuesday, so please rebase when you get the chance!

@iris-xie
Copy link

when this patch can be merged into main branch? we are also facing the same issue. pls hurry

@crw
Copy link
Contributor

crw commented Aug 19, 2025

@xingjiu FYI, the window for inclusion in 1.13 is closed, and the window for 1.14 is closing fast. Could you please rebase so we can merge this PR? Thanks!

@xingjiu xingjiu force-pushed the fix/oss_backend_proxy branch 2 times, most recently from 9ff6786 to 82a83e4 Compare August 28, 2025 10:31
@xingjiu xingjiu force-pushed the fix/oss_backend_proxy branch from 064524c to 5a879c0 Compare August 29, 2025 00:36
@xingjiu
Copy link
Contributor Author

xingjiu commented Aug 29, 2025

Hi @xiaozhu36 @xiehan @crw, sorry for the delay on my end. I’ve just rebased the fix/oss_backend_proxy branch onto the latest main (conflicts resolved) and force-pushed.

@DanielMSchmidt DanielMSchmidt merged commit 1baef44 into hashicorp:main Sep 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSS backend does not recognize NO_PROXY environment variable, causing unintended proxy usage
7 participants