-
Notifications
You must be signed in to change notification settings - Fork 10k
Fix #36897: Resolve NO_PROXY recognition issue in oss remote backend #36898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@xiaozhu36 per codeowners |
@xiaozhu36 Friendly reminder to please review this backend PR. If we want to include this in the 1.13 release, it needs to be approved and merged within the next couple of weeks. |
@xiehan I have reviewed the PR and there is no problem. |
Great! @xingjiu Could you rebase your PR? |
@xingjiu If you want this to be included in 1.13.0, it needs to be merged by next Tuesday, so please rebase when you get the chance! |
when this patch can be merged into main branch? we are also facing the same issue. pls hurry |
@xingjiu FYI, the window for inclusion in 1.13 is closed, and the window for 1.14 is closing fast. Could you please rebase so we can merge this PR? Thanks! |
9ff6786
to
82a83e4
Compare
064524c
to
5a879c0
Compare
Hi @xiaozhu36 @xiehan @crw, sorry for the delay on my end. I’ve just rebased the fix/oss_backend_proxy branch onto the latest main (conflicts resolved) and force-pushed. |
Fixes #36897
This PR addresses [Terraform Issue #36897]. The core implementation was previously contributed to OpenTofu PR #2675 and is adapted here to fit Terraform's codebase.
Target Release
1.13.x
CHANGELOG entry