v1.8 Backport of #35157 #35162
Merged
v1.8 Backport of #35157 #35162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A walk can start from multiple roots, so making the Ancestors and Descendents methods variadic is the easiest way to add access to that via the API with no changes in existing callers. We can use this from terraform to avoid repeatedly walking overlapping sets of nodes.
The existing implementation of parentModuleDependsOn would walk each reference separately, but if there were many dependencies which were all interconnected, that would end up walking over the same nodes multiple times, and storing many duplicate results. Since a graph walk can start at multiple nodes, we use the extended version of Ancestors to start at all dependencies simultaneously, reducing the time spend traversing the graph as well as automatically removing duplicates.
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manual backport of #35157
The use of
depends_onin modules can cause large numbers of nodes to become connected to all of the same dependencies. When usingAncestorsto walk the graph and find all of these dependencies, there can be a lot of redundant ancestors shared between each of the original nodes, causing an exponential increase in processing time and memory use.Instead of traversing the graph from each dependency individually, which can frequently end up duplicating results, we can start a walk from all nodes at once, reducing the redundant graph traversals and automatically removing duplicates.
Fixes #35154