deferred actions: add common functionality for evaluating unexpanded and expanded modules #35009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and expanded modules
liamcervante
force-pushed
the
liamcervante/deferred-references
branch
from
fb782b5
to
ab6a8b5
Compare
jbardin
approved these changes
Apr 26, 2024
internal/terraform/evaluate_state.go
Outdated
|
|
||
| // evaluationStateData is an implementation of lang.Data that resolves | ||
| // references primarily (but not exclusively) using information from a State. | ||
| type evaluationStateData struct { |
There was a problem hiding this comment.
Any reason to not leave this in the original file, at least so that the git history is easier to follow? It's also hard to compare for changes in this PR in particular.
There was a problem hiding this comment.
I just thought the separation of the various implementations into dedicated files was a slightly better layout. I don't feel strongly though so moved it back to preserve the git history as that seems reasonable!
|
(Just a little comment spam to backlink this from its related issue #30937) |
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step towards completing the implementation of evaluate_placeholder.go.
We create a shared subclass,
evaluateData, that bothevaluatePlaceholderDataandevaluateStateDatashare. Both of these classes now pass off the common implementations that they share to the same shared functions. Functions and structs have been moved around here, but there's no real functionality changes. The only difference is thatevaluatePlaceholderDatahas now properly implementedGetPathAttrandGetTerraformAttr.A follow up PR will implement the remaining functions within evaluatePlaceholderData, but I wanted to do this refactor first to keep the interesting diff clear.