Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: standardize use of the id attribute design decision #40627

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

doc: standardize use of the id attribute design decision #40627

wants to merge 2 commits into from

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Dec 18, 2024

Description

This is a public-facing copy of an internal RFC which has already been approved by maintainers of the AWS provider. The goal of publishing this is to share the research and tradeoffs behind the decision, and document best practices going forward.

Rendered version.

@jar-b jar-b requested a review from a team as a code owner December 18, 2024 20:42
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Dec 18, 2024
@jar-b
doc: standardize use of the id attribute design decision
e8c98e5 
This is a public-facing copy of an internal RFC which has already been approved by maintainers of the AWS provider. The goal of publishing this is to share the research and tradeoffs behind the decision, and document best practices going forward.
@jar-b jar-b force-pushed the d-resource-id-design-decision branch from 3fb6308 to e8c98e5 Compare December 18, 2024 20:50
ewbankkit
ewbankkit approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jar-b @ewbankkit