Fix for default_tags and tags on EC2 block devices #37441
+2
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
default_tags
support for EC2 root block devices was introduced in #33769, which is great ... except it makes the mix ofdefault_tags
andtags
on aroot_block_device
perpetually showing drift even when there is none.The solution is to not remove the default tags config from the volume tags in ec2_instance.
This diff fixes #36448 for us in our environment (which references #33769 as the change that introduced this bug).
This diff possibly fixes #36706 too, but we weren't hitting this issue.
Relations
Relates #33769
Relates #36706
Closes #36448
Output from Acceptance Testing