Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate vpnclient resources to AWS Go SDKv2 #37390

Merged
merged 18 commits into from May 20, 2024
Merged

Migrate vpnclient resources to AWS Go SDKv2 #37390

merged 18 commits into from May 20, 2024

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented May 9, 2024 •
edited

Description

This PR migrates vpnclient resources to AWS SDKv2

Relations

Closes #36221

References

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 1  -run=TestAccClientVPNEndpoint_serial -timeout 360m
=== RUN   TestAccClientVPNEndpoint_serial
=== PAUSE TestAccClientVPNEndpoint_serial
=== CONT  TestAccClientVPNEndpoint_serial
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_withDNSServers
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_withDNSServers
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_vpcSecurityGroups
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_vpcSecurityGroups
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_basic
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basic
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_withClientConnect
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_withClientConnect
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_withLogGroup
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_withLogGroup
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_msADAuth
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_msADAuth
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_federatedAuth
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_federatedAuth
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_tags
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_tags
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_withClientLoginBanner
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_withClientLoginBanner
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_vpcNoSecurityGroups
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_vpcNoSecurityGroups
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_groups
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_groups
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_subnets
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_subnets
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== RUN   TestAccClientVPNEndpoint_serial/Route_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/Route_disappears
=== RUN   TestAccClientVPNEndpoint_serial/Route_basic
=== PAUSE TestAccClientVPNEndpoint_serial/Route_basic
=== RUN   TestAccClientVPNEndpoint_serial/Route_description
=== PAUSE TestAccClientVPNEndpoint_serial/Route_description
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_withDNSServers
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== CONT  TestAccClientVPNEndpoint_serial/Route_description
=== CONT  TestAccClientVPNEndpoint_serial/Route_basic
=== CONT  TestAccClientVPNEndpoint_serial/Route_disappears
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_subnets
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_vpcNoSecurityGroups
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_groups
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_withLogGroup
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_basic
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_withClientConnect
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_withClientLoginBanner
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_vpcSecurityGroups
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_tags
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_federatedAuth
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_msADAuth
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
--- PASS: TestAccClientVPNEndpoint_serial (4.52s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_withDNSServers (111.50s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal (36.27s)
    --- PASS: TestAccClientVPNEndpoint_serial/Route_description (944.50s)
    --- PASS: TestAccClientVPNEndpoint_serial/Route_basic (872.55s)
    --- PASS: TestAccClientVPNEndpoint_serial/Route_disappears (911.35s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears (920.52s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets (1003.73s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_basic (811.55s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_subnets (88.31s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears (59.29s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_vpcNoSecurityGroups (32.42s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_groups (114.54s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_basic (62.34s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (52.51s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_withLogGroup (67.24s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basic (22.18s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth (2044.18s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_withClientConnect (103.09s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_disappears (20.23s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService (23.52s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_withClientLoginBanner (50.32s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_vpcSecurityGroups (49.97s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_tags (51.19s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_federatedAuth (22.63s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource (21.28s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_msADAuth (2063.84s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate (37.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	10603.105s

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpnclient Issues and PRs that pertain to the vpnclient service. labels May 9, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 9, 2024
@DanielRieske DanielRieske changed the title Migrate vpnclient service to AWS Go SDKv2 #37277 Migrate vpnclient service to AWS Go SDKv2 May 9, 2024
@DanielRieske DanielRieske changed the title Migrate vpnclient service to AWS Go SDKv2 Migrate vpnclient resources to AWS Go SDKv2 May 9, 2024
@justinretzolk justinretzolk added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels May 9, 2024
@ewbankkit ewbankkit self-assigned this May 20, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 20, 2024
ewbankkit
ewbankkit approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccClientVPNEndpoint_serial' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccClientVPNEndpoint_serial -timeout 720m
=== RUN   TestAccClientVPNEndpoint_serial
=== PAUSE TestAccClientVPNEndpoint_serial
=== CONT  TestAccClientVPNEndpoint_serial
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_groups
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_groups
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_subnets
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_subnets
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== RUN   TestAccClientVPNEndpoint_serial/Route_basic
=== PAUSE TestAccClientVPNEndpoint_serial/Route_basic
=== RUN   TestAccClientVPNEndpoint_serial/Route_description
=== PAUSE TestAccClientVPNEndpoint_serial/Route_description
=== RUN   TestAccClientVPNEndpoint_serial/Route_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/Route_disappears
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_msADAuth
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_msADAuth
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_federatedAuth
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_federatedAuth
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_withClientLoginBanner
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_withClientLoginBanner
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_vpcSecurityGroups
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_vpcSecurityGroups
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_withClientConnect
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_withClientConnect
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_withLogGroup
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_withLogGroup
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_tags
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_tags
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_basic
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basic
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_withDNSServers
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_withDNSServers
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_vpcNoSecurityGroups
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_vpcNoSecurityGroups
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_federatedAuth
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_withDNSServers
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_basic
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_vpcNoSecurityGroups
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_msADAuth
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_groups
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_subnets
=== CONT  TestAccClientVPNEndpoint_serial/Route_basic
=== CONT  TestAccClientVPNEndpoint_serial/Route_disappears
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets
=== CONT  TestAccClientVPNEndpoint_serial/Route_description
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_withLogGroup
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_tags
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_vpcSecurityGroups
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_withClientConnect
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_withClientLoginBanner       
--- PASS: TestAccClientVPNEndpoint_serial (4.35s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_disappears (16.36s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (44.40s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource (36.54s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears (839.01s)
    --- PASS: TestAccClientVPNEndpoint_serial/Route_disappears (894.38s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_withDNSServers (931.30s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_groups (932.94s)
    --- PASS: TestAccClientVPNEndpoint_serial/Route_basic (952.51s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_basic (985.28s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_federatedAuth (17.68s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal (27.71s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService (16.95s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_subnets (1025.65s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basic (1042.13s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears (1053.91s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_vpcNoSecurityGroups (1065.13s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets (1069.45s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate (1074.43s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_withLogGroup (1096.21s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_tags (1095.38s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_vpcSecurityGroups (273.69s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_withClientConnect (323.41s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_withClientLoginBanner (358.33s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_basic (1000.68s)
    --- PASS: TestAccClientVPNEndpoint_serial/Route_description (1943.86s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_msADAuth (2772.62s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth (2819.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	2827.604s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit cfd77cd into hashicorp:main May 20, 2024
35 checks passed
@github-actions github-actions bot added this to the v5.51.0 milestone May 20, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 24, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. external-maintainer Contribution from a trusted external contributor. service/vpnclient Issues and PRs that pertain to the vpnclient service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.51.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] VPN (Client) Service
3 participants
@DanielRieske @ewbankkit @justinretzolk