Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_imagebuilder_pipeline: add support for workflows #37317

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kamilturek
Copy link
Collaborator

Description

This PR adds support for Image Builder workflows to Image Builder pipelines. Similar to #36953.

Relations

Closes #35045.

References

https://aws.amazon.com/about-aws/whats-new/2023/12/ec2-image-builder-image-workflows/
https://docs.aws.amazon.com/imagebuilder/latest/APIReference/API_CreateImagePipeline.html
https://docs.aws.amazon.com/imagebuilder/latest/APIReference/API_UpdateImagePipeline.html

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccImageBuilderImagePipeline_workflow" PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/imagebuilder/... -v -count 1 -parallel 20  -run=TestAccImageBuilderImagePipeline_workflow -timeout 360m
=== RUN   TestAccImageBuilderImagePipeline_workflow
=== PAUSE TestAccImageBuilderImagePipeline_workflow
=== RUN   TestAccImageBuilderImagePipeline_workflowParameter
=== PAUSE TestAccImageBuilderImagePipeline_workflowParameter
=== CONT  TestAccImageBuilderImagePipeline_workflow
=== CONT  TestAccImageBuilderImagePipeline_workflowParameter
--- PASS: TestAccImageBuilderImagePipeline_workflow (43.19s)
--- PASS: TestAccImageBuilderImagePipeline_workflowParameter (43.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       48.232s

Copy link

github-actions bot commented May 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. labels May 7, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 7, 2024
@kamilturek kamilturek marked this pull request as ready for review May 7, 2024 08:26
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support for Image Builder workflows
2 participants