Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Dropdowns on the jobs index page get a max-height and filtering #20626

Merged
merged 2 commits into from
May 30, 2024

Conversation

philrenaud
Copy link
Contributor

Before:
image
After:
image

@david-yu
Copy link
Contributor

Thanks for doing this!

Copy link

github-actions bot commented May 17, 2024

Ember Test Audit comparison

main 6d902f3 change
passes 1563 1564 +1
failures 0 0 0
flaky 0 0 0
duration 11m 25s 357ms 11m 43s 020ms +17s 663ms

@gulducat
Copy link
Member

this is great for several-many namespaces! maybe the box could be just a little taller? or screen height as before, but with a scrollbar?

for very-many, though (thousands?), the little box is still kinda unwieldy. a filter/search box on the dropdown would be real neat if you can swing it!

@david-yu
Copy link
Contributor

Would be awesome if we could get this in for 1.8.0.

@philrenaud
Copy link
Contributor Author

for very-many, though (thousands?), the little box is still kinda unwieldy. a filter/search box on the dropdown would be real neat if you can swing it!

@gulducat updated with a lil' searchbox!

Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@philrenaud philrenaud added the backport/1.8.x backport to 1.8.x release line label May 24, 2024
@philrenaud philrenaud force-pushed the f-ui/dropdowns-are-out-of-control branch from 2c6d679 to 6d902f3 Compare May 29, 2024 20:41
@philrenaud philrenaud changed the title [ui] Dropdowns on the jobx index page get a max-height [ui] Dropdowns on the jobs index page get a max-height May 30, 2024
@philrenaud philrenaud changed the title [ui] Dropdowns on the jobs index page get a max-height [ui] Dropdowns on the jobs index page get a max-height and filtering May 30, 2024
@philrenaud philrenaud merged commit 1412e65 into main May 30, 2024
15 checks passed
@philrenaud philrenaud deleted the f-ui/dropdowns-are-out-of-control branch May 30, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.8.x backport to 1.8.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants